undo history not working, when line-endings change after save

[zaggino]

For a bug identified in #11826 (comment)

credits to @vahid-sanati for identifying this, put up a PR so we can have it merged asap

cc @petetnt @ficristo

[ficristo]

The test added in #12681 probably should be updated or we should add a new one for this case.
It exists a Document.normalizeText which normalize line endings: maybe we should update to check also for \r and use it, but it doesn't check for null text, so maybe not.

Looking at the commits for 1.5 release-1.4...release-1.5
there are a couple of upgrade of CodeMirror. In that version of CodeMirror it was changed a bit the way new line endings where used and maybe that broke some assumptions of Brackets.

[petetnt]

Would it be worth it to extract and extend Document.normalizeText to FileUtils.js with other line ending related methods? Then we could just use FileUtils.normalizeLineEndings(text) which would return normalized text or null.

The solution for the problem LGTM, just 🚲 🏠

[zaggino]

I wanted to use FileUtils.normalizeLineEndings but when I included it in the file it lead to circular dependencies and whole Brackets broke 😒 Really hate requirejs

[zaggino]

Feel free to push/modify this branch if you want, I have very little time to give to this urgently.

[petetnt]

Really hate requirejs

Ditto. I say lets merge this now and bikeshed the normalization later.

[ficristo]

If you want to merge go ahead, but a test is really needed here. At least file a followup for it.

[zaggino]

put up a test;

• i believe that CM is returning always \n line-endings after the change @ficristo mentioned but i don't have time to investigate properly

[ficristo]

AFAIK if the lineSeparator option is not set CodeMirror return always \n line endings.

[petetnt]

Kinda worried about possible performance issues with larger files (possibly leading to External file changes-dialogs?) but otherwise LGTM.

[swmitra]

Merging.

[swmitra]

Great work @vahid-sanati @zaggino @ficristo @petetnt