This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
[OPEN] Add syntax wirings for .scala, .sbt, .properties, and .ini #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging [OPEN] for community review. Also, I wonder if we should add block/line comment properties to these (it looks like they're missing for some other languages like Java as well). |
ghost
assigned
|
@andyscott - sorry it's taken awhile to get to this. The code looks fine, but it seems like it would be worth adding block/line comment properties to these (at least for Scala; I don't know enough about the other cases to know whether that's appropriate). Could you take a look at that? Also, please merge with the current master. Thanks. |
|
Actually, it looks like we don't have comment syntax for Java and many other languages either, so I won't hold this up for that. I'll manually merge with master. |
|
Merged as f03b4b6. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.