Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[UX] Issue #4174 - Add find next / previous buttons for easy navigation #5002

Merged
merged 3 commits into from
Sep 6, 2013

Conversation

rajeshsegu
Copy link

Add next/previous buttons to Find modal bar for easy navigation between matches.

Handles cases

  1. Find has matching results
  2. Find has no matching results
  3. Large documents

screen shot 2013-08-29 at 5 38 26 pm png

@pthiess
Copy link
Contributor

pthiess commented Aug 30, 2013

@larz0 Please take a look, you have reviewed #4175 already.

@larz0
Copy link
Member

larz0 commented Aug 30, 2013

@rajeshsegu Could you update ".modal-bar .navigator button" so the buttons line up with the search input?

You can probably fix that by removing ".modal-bar .navigator button" block in CSS.

Done with initial review.

@rajeshsegu
Copy link
Author

Thanks @larz0 . I think we still need the margin's to offset the border / etc. Here is the new screenshot
screen shot 2013-08-30 at 1 22 13 pm png

@larz0
Copy link
Member

larz0 commented Aug 30, 2013

Ok cool. Looks good~

larz0 added a commit that referenced this pull request Sep 6, 2013
[UX] Issue #4174 - Add find next / previous buttons for easy navigation
@larz0 larz0 merged commit 2e800ef into adobe:master Sep 6, 2013
@larz0
Copy link
Member

larz0 commented Sep 6, 2013

Thanks for this @rajeshsegu just realized I can merge it since it's assigned to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants