Implement jscodehints.defaultExclusions preference. #7739
Conversation
We've had a number of people report problems with Ionic in their projects. Tern appears to have an issue with the minified Ionic files. I had planned to add default exclusions so that we could quickly solve pain like this and this problem appeared to be a good candidate. The repro steps [reported here](#7262 (comment)) are fixed with this change.
| // file in your project. | ||
| if (defaultExclusions | ||
| && _.isArray(defaultExclusions) | ||
| && _.some(defaultExclusions, _.partial(checkExclusion, name))) { |
|
I have changed the code to use globmatch, per @redmunds feedback. I tried "*.min.js" just to see how that would work out. I decided against it, because lodash.min.js actually produces fine hints and causes no trouble for Tern. |
|
@dangoor Given the rising number of reports we've gotten specifically around Ionic, do you think this is worth cherry-picking into the EC release? |
|
Point of reference -- I was able to reproduce this eventually with the steps listed in the issue on Mac but the steps don't work on Windows. I presume because the cordova ios package isn't available on Windows for some reason. I tested it on both mac and windows with the exclusions and it doesn't WSOD. Code looks good. I presume we want to take this for Release 39? |
|
@JeffryBooher yes, for 39 @peterflynn Good question. I don't think this change is risky and should be an easy merge, but it's also kind of late and Ionic is not quite like jQuery in terms of userbase... Given that we still need to do the EC release testing, it may be worth taking this – I think potential bugs would present themselves pretty quickly. |
|
Merging |
Implement jscodehints.defaultExclusions preference.
We've had a number of people report problems with Ionic in their projects.
Tern appears to have an issue with the minified Ionic files. I had planned
to add default exclusions so that we could quickly solve pain like this
and this problem appeared to be a good candidate. The repro steps
reported here
are fixed with this change.
#7262