Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for running docker daemon #178

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

shanejbrown
Copy link
Contributor

@shanejbrown shanejbrown commented Feb 19, 2025

What does this PR do?

Adds a check to see if the docker daemon is running. If the daemon is not running it will print the exception with a message to check that the docker daemon is running and try again.

What issues does this PR fix or reference?

Without this check when you run buildrunner without the docker daemon running you get a vague error message.

Previous Behavior

Without this check when you run buildrunner without the docker daemon running you get the following vague error message:

docker.errors.DockerException: Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))

New Behavior

Now when you run buildrunner without the docker daemon running you get the following message:

buildrunner.docker.BuildRunnerContainerError: Error connecting to Docker daemon. Please ensure the Docker daemon is running and try again.

Merge requirements satisfied?

  • I have updated the documentation or no documentation changes are required.
  • I have added tests to cover my changes.
  • I have updated the base version in setup.py (if appropriate).

@shanejbrown shanejbrown merged commit 0f891ac into adobe:main Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants