Skip to content

Commit

Permalink
fix: update node engines to 18+, CI to test 18, 20, adobe deps (#3)
Browse files Browse the repository at this point in the history
  • Loading branch information
shazron authored Jan 12, 2024
1 parent 99584cd commit 9b57adf
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [14]
node-version: [18]
os: [ubuntu-latest]

steps:
Expand All @@ -30,5 +30,5 @@ jobs:
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_TITLE: 'Node version'
SLACK_MESSAGE: ${{ matrix.node }}
SLACK_MESSAGE: ${{ matrix.node-version }}
SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }}
9 changes: 4 additions & 5 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [18.x, 20.x]
os: [ubuntu-latest, windows-latest]

steps:
Expand All @@ -31,7 +31,6 @@ jobs:
- run: npm test
- name: upload coverage
if: success()
run: curl -s https://codecov.io/bash | bash
env:
CODECOV_NAME: ${{ runner.os }} node.js ${{ matrix.node-version }}
shell: bash
uses: codecov/[email protected]
with:
name: ${{ runner.os }} node.js ${{ matrix.node-version }}
2 changes: 1 addition & 1 deletion .github/workflows/on-push-publish-to-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 18
- run: npm install
- run: npm test
- uses: JS-DevTools/npm-publish@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prerelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
git config user.email [email protected]
- uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
- run: |
npm install
npm test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/version-bump-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
git config user.email [email protected]
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 18
- run: |
npm install
npm test
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Extensibility template for generating an Adobe Target App Builder action",
"main": "index.js",
"engines": {
"node": "^14.18 || ^16.13 || >=18"
"node": ">=18"
},
"keywords": [
"ecosystem:aio-app-builder-template"
Expand All @@ -22,7 +22,7 @@
"author": "Adobe Inc.",
"license": "Apache-2.0",
"devDependencies": {
"@adobe/aio-lib-template-validation": "^4.0.0",
"@adobe/aio-lib-template-validation": "^5",
"@types/jest": "^27.4.1",
"eol": "^0.9.1",
"eslint": "^7.1.0",
Expand All @@ -32,7 +32,7 @@
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-standard": "^4.0.1",
"jest": "^27",
"jest": "^29",
"js-yaml": "^4.1.0",
"lodash.clonedeep": "^4.5.0",
"stdout-stderr": "^0.1.13",
Expand All @@ -41,7 +41,7 @@
"yeoman-test": "^6.0.0"
},
"dependencies": {
"@adobe/generator-app-common-lib": "^0.3.3",
"@adobe/generator-app-common-lib": "^2",
"lodash.camelcase": "^4.3.0",
"upath": "^2.0.1",
"yeoman-generator": "^5.4.2"
Expand Down

0 comments on commit 9b57adf

Please sign in to comment.