"Could not fetch Infinity Model" masks other errors

[digitalcora]

At a couple places in the route mixin (here and here), there is a promise failure handler that catches all errors and throws a generic "Could not fetch Infinity Model" error. This makes it quite difficult to determine what the actual error was – in my case the server response was successful, and I had to do some "pause on all exceptions" debugging to find out that it was ember-data telling me an association wasn't set up correctly. Is there an advantage to doing things this way? Why not allow the real error to surface?

[hhff]

thanks @Grantovich - yeah that's a good point. I think we should probably remove all error handling from server promises, and leave them only for validation type errors.

@mkorfmann @mike-north @kellyselden - thoughts / tips here?

[hhff]

just chatted with @mkorfmann - we'd like to ensure we return the error from the promise callback, but instead of throwing, we'll log an Ember.warn. That way nothing will be swallowed - and the error will be clearly ember-infinity related

We're waiting for #88 to get into the codebase before doing new work on it - so we'll get to this hopefully soon - thankyou @Grantovich !

[digitalcora]

Thanks for the prompt response 😺 I look forward to those changes.

[davidgoli]

@Grantovich FYI #88 has merged

[hhff]

@Grantovich - feel like writing a PR for this? ❤️

[digitalcora]

This was something I encountered on a free-time project that I work on very infrequently, so I'm not sure if I'll be able to get to it in the near future 😿 I'll update here if I find some time to work on it.

[hhff]

kk - thanks anywhoo @Grantovich !

[davidgoli]

Fixed with #125