Don't swallow errors when loading records #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
changed the title
hhff
added a commit
that referenced
this pull request
Dec 21, 2015
Don't swallow errors when loading records
|
Rad - thankyou @philipp-spiess ! This has been bugging us for a while 👍 |
This was referenced Dec 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior would swallow all errors that could occur while loading records and prints an obscure error message.
This is bad because:
afterInfinityModelhook, it won't display possible errors - this took me a few minutes to figure out what's wrong.It's safer to leave the original error messages as is and don't swallow errors in favor of a more generic one.