Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel.js polyfill in demo app #36

Merged
merged 3 commits into from
Jun 18, 2015
Merged

Babel.js polyfill in demo app #36

merged 3 commits into from
Jun 18, 2015

Conversation

mike-north
Copy link
Collaborator

Addresses issues in #33

@mike-north mike-north mentioned this pull request Jun 18, 2015
Merged
mike-north
mike-north reviewed Jun 18, 2015
View reviewed changes
.travis.yml
@@ -20,6 +20,7 @@ env:
matrix:
fast_finish: true
allow_failures:
- env: EMBER_TRY_SCENARIO=ember-beta
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhff Looks like you're aware that there are some ember 2.0 issues (#32). For now I think you guys should allow test failures in "beta", and then once you get the 2.0 issues fixed, stop allowing those failures

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Mike! Hadn't had a chance to check this yet

hhff added a commit that referenced this pull request Jun 18, 2015
@hhff
Merge pull request #36 from truenorth/babel-polyfill-in-demo
7d7a18c 
Babel.js polyfill in demo app
@hhff hhff merged commit 7d7a18c into adopted-ember-addons:master Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-north @hhff