Added support for moment().calendar() with moment-calendar #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing because of timezone difference |
|
@jasonmit yep, fixing now. |
|
👍 thanks for working on this |
|
No worries, we've actually had the code sitting in our app for a while, just decided to extract it so we could remove the tests from our suite. |
Fixed applying tz and locale Clarify dates in tests a bit Timezones are hard
ivanvanderbyl
force-pushed
the
feature/add-moment-calendar-support
branch
from
cdfbca8 to
67b7b9c
Compare
|
@jasonmit should be ready to roll! |
|
Looks great, thanks again! |
jasonmit
added a commit
that referenced
this pull request
Jan 19, 2016
…r-support Added support for moment().calendar() with moment-calendar
|
Versioned as 5.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
moment().calendar()— Calendar Time display, and addresses #126Usage:
Produces such outputs as: