Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump botocore dependency specification #1292

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Feb 12, 2025

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains several changes that require minor adjustments to the aiobotocore codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Feb 12, 2025
@jakob-keller jakob-keller self-assigned this Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.78%. Comparing base (3eabc88) to head (2498e62).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/httpchecksum.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
- Coverage   89.88%   89.78%   -0.11%     
==========================================
  Files          67       67              
  Lines        6083     6087       +4     
==========================================
- Hits         5468     5465       -3     
- Misses        615      622       +7     
Flag Coverage Δ
unittests 89.78% <57.14%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the bump-botocore branch 2 times, most recently from 02d28b7 to a540cd5 Compare February 14, 2025 22:14
@jakob-keller
Copy link
Collaborator Author

Test coverage is slightly lower, but the non-covered lines are also not tested in upstream. I'd say this is fine.

@jakob-keller jakob-keller marked this pull request as ready for review February 19, 2025 19:17
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks for the review and approval! Is there a way for you to unblock the PR, i.e. force it into the merge queue despite the coverage fail? I can't do that AFAIK.

@thehesiod thehesiod disabled auto-merge February 20, 2025 01:05
@thehesiod thehesiod merged commit d65c685 into aio-libs:master Feb 20, 2025
17 of 18 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch February 20, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants