-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump botocore
dependency specification
#1292
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1292 +/- ##
==========================================
- Coverage 89.88% 89.78% -0.11%
==========================================
Files 67 67
Lines 6083 6087 +4
==========================================
- Hits 5468 5465 -3
- Misses 615 622 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
02d28b7
to
a540cd5
Compare
a540cd5
to
f73a059
Compare
f73a059
to
2498e62
Compare
Test coverage is slightly lower, but the non-covered lines are also not tested in upstream. I'd say this is fine. |
@thehesiod: Thanks for the review and approval! Is there a way for you to unblock the PR, i.e. force it into the merge queue despite the coverage fail? I can't do that AFAIK. |
Description of Change
This PR intends to improve general compatibility of
aiobotocore
within the Python ecosystem by bumping the dependency specification ofbotocore
, as well asboto3
andawscli
.Assumptions
Upstream diff contains several changes that require minor adjustments to the aiobotocore codebase.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions