Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable autofix PRs by pre-commit.ci #1299

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Disable pre-commit.ci auto fixing of PRs: https://pre-commit.ci/#configuration-autofix_prs

Assumptions

Auto-fixing is undesirable

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes pre-commit.ci should not autofix PRs #1298
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Feb 17, 2025
@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Feb 17, 2025
@jakob-keller jakob-keller force-pushed the pre-commit.ci-no-autofix branch from 8e1e266 to 7c14e5d Compare February 17, 2025 08:36
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (817130f) to head (7c14e5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   88.69%   88.61%   -0.09%     
==========================================
  Files          67       67              
  Lines        5875     5875              
==========================================
- Hits         5211     5206       -5     
- Misses        664      669       +5     
Flag Coverage Δ
unittests 88.61% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller added this pull request to the merge queue Feb 17, 2025
Merged via the queue into aio-libs:master with commit 7c41f8a Feb 17, 2025
18 checks passed
@jakob-keller jakob-keller deleted the pre-commit.ci-no-autofix branch February 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit.ci should not autofix PRs
2 participants