Fix #3186: Return empty bytes with end-of-chunk marker in empty strea…

…m reader.
aio-libs · Sep 26, 2018 · b4063a9 · b4063a9
1 parent da75122
commit b4063a9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES/3186.bugfix b/CHANGES/3186.bugfix
@@ -0,0 +1 @@
+Return empty bytes with end-of-chunk marker in empty stream reader.
diff --git a/aiohttp/streams.py b/aiohttp/streams.py
@@ -482,7 +482,7 @@ async def readany(self) -> bytes:
         return b''
 
     async def readchunk(self) -> Tuple[bytes, bool]:
-        return (b'', False)
+        return (b'', True)
 
     async def readexactly(self, n: int) -> bytes:
         raise asyncio.streams.IncompleteReadError(b'', n)

diff --git a/tests/test_streams.py b/tests/test_streams.py
@@ -750,7 +750,7 @@ async def test_empty_stream_reader() -> None:
     assert await s.read() == b''
     assert await s.readline() == b''
     assert await s.readany() == b''
-    assert await s.readchunk() == (b'', False)
+    assert await s.readchunk() == (b'', True)
     with pytest.raises(asyncio.IncompleteReadError):
         await s.readexactly(10)
     assert s.read_nowait() == b''
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Return empty bytes with end-of-chunk marker in empty stream reader.