Skip to content

Commit

Permalink
Small updates to contributors guide (#4825) (#5043)
Browse files Browse the repository at this point in the history
* docs/contributing: refer to latest version of contrib guide

* docs/contributing: grammer fix

* docs/contributing: fix command for test coverage report

* added CHANGES file

(cherry picked from commit f079e36)

Co-authored-by: Guus Bertens <[email protected]>
  • Loading branch information
patchback[bot] and guusbertens authored Oct 15, 2020
1 parent 36f402a commit eb581ae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES/4810.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update contributing guide so new contributors read the most recent version of that guide. Update command used to create test coverage reporting.
7 changes: 5 additions & 2 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ I hope everybody knows how to work with git and github nowadays :)

Workflow is pretty straightforward:

0. Make sure you are reading the latest version of this document.
It can be found in the GitHub_ repo in the ``docs`` subdirectory.

1. Clone the GitHub_ repo using the ``--recurse-submodules`` argument

2. Setup your machine with the required dev environment
Expand All @@ -20,7 +23,7 @@ Workflow is pretty straightforward:

4. Make sure all tests passed

5. Add a file into ``CHANGES`` folder (see `Changelog update`_ for how).
5. Add a file into the ``CHANGES`` folder (see `Changelog update`_ for how).

6. Commit changes to your own aiohttp clone

Expand Down Expand Up @@ -131,7 +134,7 @@ Use:

.. code-block:: shell
$ make cov
$ make cov-dev
to run test suite and collect coverage information. Once the command
has finished check your coverage at the file that appears in the last
Expand Down

0 comments on commit eb581ae

Please sign in to comment.