Is break in finally intentional?

[asvetlov]

In low-level server code I see break statements inside finally blocks like https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/server.py#L290

It looks suspicious: break inside finally block discards saved exception (see https://docs.python.org/3.5/reference/simple_stmts.html#break).
I believe return should be used instead, it does the same in the case (stop reading incoming data) but it is show the intention much more explicitly.

@fafhrd91 you are author of these lines. Do you remember the motivation for break statement?

[fafhrd91]

I do not really remember, but good catch let's replace with returns

Sent from my iPhone

On Jul 27, 2015, at 7:53 AM, Andrew Svetlov [email protected] wrote:

In low-level server code I see break statements inside finally blocks like https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/server.py#L290

It looks suspicious: break inside finally block discards saved exception (see https://docs.python.org/3.5/reference/simple_stmts.html#break).
I believe return should be used instead, it does the same in the case (stop reading incoming data) but it is shows the intention much more explicitly.

@fafhrd91 you are author of these lines. Do you remember the motivation for break statement?

—
Reply to this email directly or view it on GitHub.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.