Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting branch protection failure in GHA #6369

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Fix setting branch protection failure in GHA #6369

merged 2 commits into from
Dec 4, 2021

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Dec 4, 2021

What do these changes do?

This is necessary to resolve the problem of GitHub treating the
skipped check job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

Are there changes in behavior for the user?

No, only for the maintainers.

Related issue number

#6330 (among others)

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz
Fix setting branch protection failure in GHA
17d2fdf 
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
aio-libs#6330.

Inspired by:
pyca/cryptography#6512 (comment)
@webknjaz webknjaz self-assigned this Dec 4, 2021
@webknjaz webknjaz enabled auto-merge (squash) December 4, 2021 01:14
@webknjaz webknjaz requested a review from asvetlov as a code owner December 4, 2021 01:18
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 4, 2021
@webknjaz webknjaz mentioned this pull request Dec 4, 2021
Merged
@webknjaz
Copy link
Member Author

webknjaz commented Dec 4, 2021

@Dreamsorcerer you're going to like this.

@codecov
Copy link

codecov bot commented Dec 4, 2021 •
edited
Loading

Codecov Report

Merging #6369 (beb6585) into master (c2762a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6369   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files         103      103           
  Lines       30377    30377           
  Branches     3058     3058           
=======================================
  Hits        28350    28350           
  Misses       1850     1850           
  Partials      177      177
Flag Coverage Δ
unit 93.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2762a7...beb6585. Read the comment docs.

@webknjaz webknjaz merged commit 13b6b4d into aio-libs:master Dec 4, 2021
@patchback
Copy link
Contributor

patchback bot commented Dec 4, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/13b6b4dde8c29074fed185900d168a27e9eb7c28/pr-6369

Backported as #6370

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 4, 2021
@webknjaz @patchback
Fix setting branch protection failure in GHA
0c451d5 
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369

(cherry picked from commit 13b6b4d)
@patchback patchback bot mentioned this pull request Dec 4, 2021
Merged
5 tasks
@patchback
Copy link
Contributor

patchback bot commented Dec 4, 2021 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/13b6b4dde8c29074fed185900d168a27e9eb7c28/pr-6369

Backported as #6371

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 4, 2021
@webknjaz @patchback
Fix setting branch protection failure in GHA
b7b9158 
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369

(cherry picked from commit 13b6b4d)
@patchback patchback bot mentioned this pull request Dec 4, 2021
Merged
5 tasks
webknjaz added a commit that referenced this pull request Dec 4, 2021
@patchback @webknjaz
[PR #6369/13b6b4dd backport][3.8] Fix setting branch protection failu…
1dd0f3a 
…re in GHA (#6370)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
webknjaz added a commit that referenced this pull request Dec 4, 2021
@patchback @webknjaz
Fix setting branch protection failure in GHA (#6371)
7f6c533 
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369

(cherry picked from commit 13b6b4d)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@webknjaz webknjaz

Labels
bot:chronographer:provided There is a change note present in this PR bug infra meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webknjaz