Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptography from 35.0.0 to 36.0.0 #6330

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 22, 2021

Bumps cryptography from 35.0.0 to 36.0.0.

Changelog

Sourced from cryptography's changelog.

36.0.0 - 2021-11-21


* **FINAL DEPRECATION** Support for ``verifier`` and ``signer`` on our
  asymmetric key classes was deprecated in version 2.1. These functions had an
  extended deprecation due to usage, however the next version of
  ``cryptography`` will drop support. Users should migrate to ``sign`` and
  ``verify``.
* The entire :doc:`/x509/index` layer is now written in Rust. This allows
  alternate asymmetric key implementations that can support cloud key
  management services or hardware security modules provided they implement
  the necessary interface (for example:
  :class:`~cryptography.hazmat.primitives.asymmetric.ec.EllipticCurvePrivateKey`).
* :ref:`Deprecated the backend argument<faq-missing-backend>` for all
  functions.
* Added support for
  :class:`~cryptography.hazmat.primitives.ciphers.aead.AESOCB3`.
* Added support for iterating over arbitrary request
  :attr:`~cryptography.x509.CertificateSigningRequest.attributes`.
* Deprecated the ``get_attribute_for_oid`` method on
  :class:`~cryptography.x509.CertificateSigningRequest` in favor of
  :meth:`~cryptography.x509.Attributes.get_attribute_for_oid` on the new
  :class:`~cryptography.x509.Attributes` object.
* Fixed handling of PEM files to allow loading when certificate and key are
  in the same file.
* Fixed parsing of :class:`~cryptography.x509.CertificatePolicies` extensions
  containing legacy ``BMPString`` values in their ``explicitText``.
* Allow parsing of negative serial numbers in certificates. Negative serial
  numbers are prohibited by :rfc:`5280` so a deprecation warning will be
  raised whenever they are encountered. A future version of ``cryptography``
  will drop support for parsing them.
* Added support for parsing PKCS12 files with friendly names for all
  certificates with
  :func:`~cryptography.hazmat.primitives.serialization.pkcs12.load_pkcs12`,
  which will return an object of type
  :class:`~cryptography.hazmat.primitives.serialization.pkcs12.PKCS12KeyAndCertificates`.
* :meth:`~cryptography.x509.Name.rfc4514_string` and related methods now have
  an optional ``attr_name_overrides`` parameter to supply custom OID to name
  mappings, which can be used to match vendor-specific extensions.
* **BACKWARDS INCOMPATIBLE:** Reverted the nonstandard formatting of
  email address fields as ``E`` in
  :meth:`~cryptography.x509.Name.rfc4514_string` methods from version 35.0.

The previous behavior can be restored with: name.rfc4514_string({NameOID.EMAIL_ADDRESS: &quot;E&quot;})

  • Allow :class:~cryptography.hazmat.primitives.asymmetric.x25519.X25519PublicKey and :class:~cryptography.hazmat.primitives.asymmetric.x448.X448PublicKey to be used as public keys when parsing certificates or creating them with </tr></table>

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [cryptography](https://github.com/pyca/cryptography) from 35.0.0 to 36.0.0.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@35.0.0...36.0.0)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 22, 2021
@github-actions github-actions bot enabled auto-merge (squash) November 22, 2021 10:04
@github-actions github-actions bot merged commit 8987460 into master Nov 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the dependabot/pip/cryptography-36.0.0 branch November 22, 2021 10:07
@Dreamsorcerer
Copy link
Member

Still merging broken PRs. Any reason not to move to personal access token, as suggested by the documentation?

@webknjaz
Copy link
Member

A personal access token would need us to maintain a separate "robot" account having too much access to the org. But it's possible to use a GitHub App token, I guess.
I wonder if this is somehow caused by the fact that Dependabot is somehow special-cased by GitHub. I have a feeling that it's their bug.

@Dreamsorcerer
Copy link
Member

It's just because it doesn't trigger a workflow run, right? So, the issue is the token, rather than dependabot.

https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token

@webknjaz
Copy link
Member

@Dreamsorcerer it did trigger the workflow run but that somehow wasn't taken into account. Let me enable the new shiny feature of requiring the checks to be produced by a certain integration (previously they can be produced by any GitHub App, not just GHA). This probably won't fix it, though. I haven't had time to experiment and learn why this is happening actually.

@webknjaz
Copy link
Member

@Dreamsorcerer you wouldn't believe in what repo I've found the cause of this bug!

🤯🤯🤯🤯🤯🤯🤯🤯🤯🤯🤯🤯🤯 pyca/cryptography#6512

webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Dec 4, 2021
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
aio-libs#6330.

Inspired by:
pyca/cryptography#6512 (comment)
@webknjaz
Copy link
Member

webknjaz commented Dec 4, 2021

@Dreamsorcerer this is how we'll put an end to broken auto-merges: #6369.

webknjaz added a commit to cherrypy/cheroot that referenced this pull request Dec 4, 2021
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
aio-libs/aiohttp#6330.

Inspired by:
pyca/cryptography#6512 (comment)
webknjaz added a commit that referenced this pull request Dec 4, 2021
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369
patchback bot pushed a commit that referenced this pull request Dec 4, 2021
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369

(cherry picked from commit 13b6b4d)
patchback bot pushed a commit that referenced this pull request Dec 4, 2021
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369

(cherry picked from commit 13b6b4d)
webknjaz added a commit that referenced this pull request Dec 4, 2021
This is necessary to resolve the problem of GitHub treating the
`skipped` `check` job result as an acceptable outcome and merging
broken Dependabot PRs with auto-merge. For example:
#6330.

Inspired by:
pyca/cryptography#6512 (comment)

PR #6369

(cherry picked from commit 13b6b4d)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants