Fixing issue #1188 (mktime call replaced by constant) #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixeing issue #1188 . mktime depends on the underlying mktime from libc and on some embedded systems it uses only a 32bit time stamp which is reaching only to year 2038.
Current coverage is 98.34% (diff: 100%)@@ master #1189 diff @@
==========================================
Files 29 29
Lines 6535 6534 -1
Methods 0 0
Messages 0 0
Branches 1095 1095
==========================================
- Hits 6427 6426 -1
Misses 56 56
Partials 52 52
|
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Sep 19, 2016
* Update cookiejar.py Fixeing issue #1188 . mktime depends on the underlying mktime from libc and on some embedded systems it uses only a 32bit time stamp which is reaching only to year 2038. * Update CONTRIBUTORS.txt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Change the call for mktime to calculate a time stamp in the far future (1/1/2100) and replace it by the resulting constant of 2208985261.0 .
Are there changes in behavior for the user?
No changes, as mktime is resulting this exact value
Related issue number
#1188
Checklist
CONTRIBUTORS.txtCHANGES.rst#isuue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.Fixing issue #1188 . mktime depends on the underlying mktime from libc and on some embedded systems it uses only a 32bit time stamp which is reaching only to year 2038.