Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early check multipart body part data sanity #1580

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Early check multipart body part data sanity #1580

merged 1 commit into from
Feb 3, 2017

Conversation

kxepal
Copy link
Member

@kxepal kxepal commented Feb 2, 2017

Raising exception on append stage simplifies a lot searches of the issue origin.

This closes #920

@fafhrd91
Copy link
Member

fafhrd91 commented Feb 2, 2017

lgtm

@fafhrd91
Copy link
Member

fafhrd91 commented Feb 2, 2017

@kxepal could you add check log entry and merge pr

@kxepal
Copy link
Member Author

kxepal commented Feb 2, 2017

@fafhrd91 I believe "check log" is changelog, right? Will do.
As for Travis, it seems like static file test is flaky - have seen this failure not a single time.

@fafhrd91
Copy link
Member

fafhrd91 commented Feb 2, 2017

yep, CHANGELOG. and close related issue.
i saw flaky test couple times

Raising exception on append stage simplifies a lot searches
of the issue origin.

This closes #920
@kxepal kxepal merged commit 71d2d0d into aio-libs:master Feb 3, 2017
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: posting multipart-formdata and integer
2 participants