Add automatically a SafeChildWatcher to the test loop #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
- Coverage 97.08% 97.07% -0.02%
==========================================
Files 38 38
Lines 7689 7695 +6
Branches 1344 1345 +1
==========================================
+ Hits 7465 7470 +5
Misses 102 102
- Partials 122 123 +1
Continue to review full report at Codecov.
|
|
@asvetlov ready for your review |
asvetlov
reviewed
Jul 11, 2017
tests/test_loop.py
Outdated
|
|
||
| @asyncio.coroutine | ||
| def test_subprocess_co(loop): | ||
| skip_if_on_windows() |
There was a problem hiding this comment.
Please replace it with @pytest.skipif decorator.
I pretty sure keeping a check alongside with test improves readability.
The fact that on Unix system we don't create automatically a child watcher makes all call to asyncio.create_subprocess_* to fail.
cecton
force-pushed
the
fix-test-event-loop
branch
from
78b503e to
78bac63
Compare
|
@asvetlov this is ready for your review |
|
Cool! |
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that on Unix system we don't create automatically a child
watcher makes all call to asyncio.create_subprocess_* to fail.
What do these changes do?
It adds a default child watcher to the test loop.
Are there changes in behavior for the user?
Any
asyncio.create_subprocess_*call in the application or during a test will work because the ChildWatcher exist (on Unix).No change for Windows.
Related issue number
#2058 #2059
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.