Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed RuntimeWarning: coroutine PayloadWriter.write_eof was never awaited by making test_write_payload_eof a coroutine #2448

Closed
wants to merge 6 commits into from
Closed

removed RuntimeWarning: coroutine PayloadWriter.write_eof was never awaited by making test_write_payload_eof a coroutine #2448

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7cc0f1
client_reqrep.py now uses async/await syntax
eteamin Oct 28, 2017
05f650f
Merge remote-tracking branch 'upstream/master' into async_await
eteamin Oct 29, 2017
ba89dd9
web_rewrite_headers_middleware.py now uses async/await syntax
eteamin Oct 29, 2017
d869b23
payload_streamer.py now uses async/await syntax
eteamin Oct 29, 2017
8284127
removed RuntimeWarning: coroutine PayloadWriter.write_eof was never a…
eteamin Oct 30, 2017
4429ee7
Merge branch 'master' into async_await
eteamin Oct 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_http_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ def acquire(writer):
return stream


def test_write_payload_eof(stream, loop):
async def test_write_payload_eof(stream, loop):
write = stream.transport.write = mock.Mock()
msg = http.PayloadWriter(stream, loop)

msg.write(b'data1')
msg.write(b'data2')
msg.write_eof()
await msg.write_eof()

content = b''.join([c[1][0] for c in list(write.mock_calls)])
assert b'data1data2' == content.split(b'\r\n\r\n', 1)[-1]
Expand Down