Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed RuntimeWarning: coroutine PayloadWriter.write_eof was never a… #2449

Merged
merged 1 commit into from
Oct 30, 2017
Merged

removed RuntimeWarning: coroutine PayloadWriter.write_eof was never a… #2449

merged 1 commit into from
Oct 30, 2017

Conversation

eteamin
Copy link
Contributor

@eteamin eteamin commented Oct 30, 2017

issue #2409

@eteamin
removed RuntimeWarning: coroutine PayloadWriter.write_eof was never a…
8284127 
…waited by making test_write_payload_eof a coroutine
@codecov-io
Copy link

Codecov Report

Merging #2449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2449   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          39       39           
  Lines        8124     8124           
  Branches     1419     1419           
=======================================
  Hits         7893     7893           
  Misses         99       99           
  Partials      132      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8764562...8284127. Read the comment docs.

asvetlov
asvetlov approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@asvetlov asvetlov merged commit 20362c5 into aio-libs:master Oct 30, 2017
@hellysmile hellysmile mentioned this pull request Oct 30, 2017
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eteamin @codecov-io @asvetlov