Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty bytes with end-of-chunk marker in empty stream reader #3295

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

asvetlov
Copy link
Member

Fixes #3186

@codecov-io
Copy link

codecov-io commented Sep 26, 2018

Codecov Report

Merging #3295 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3295   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          43       43           
  Lines        8001     8001           
  Branches     1354     1354           
=======================================
  Hits         7844     7844           
  Misses         65       65           
  Partials       92       92
Impacted Files Coverage Δ
aiohttp/streams.py 99.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da75122...b4063a9. Read the comment docs.

@asvetlov asvetlov merged commit 27b586b into master Sep 26, 2018
@asvetlov asvetlov deleted the fix-empty-stream-reader branch September 26, 2018 23:38
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request.content.iter_chunks() stalls when content is empty.
2 participants