Support registering OPTIONS HTTP method handlers via RouteTableDef #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@meetmangukiya please add tests and a change fragment |
meetmangukiya
force-pushed
the
route-table-deff
branch
from
d298a02 to
29ef94f
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
meetmangukiya
force-pushed
the
route-table-deff
branch
from
29ef94f to
62b445d
Compare
|
@webknjaz added the tests |
webknjaz
reviewed
Mar 26, 2020
webknjaz
approved these changes
Mar 26, 2020
webknjaz
changed the title
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
PR #4615 by @meetmangukiya Fixes #4663 Co-authored-by: Sviatoslav Sydorenko <[email protected]>
1 task
asvetlov
pushed a commit
that referenced
this pull request
Nov 19, 2021
PR #4615 by @meetmangukiya Fixes #4663 Co-authored-by: Sviatoslav Sydorenko <[email protected]>
asvetlov
pushed a commit
that referenced
this pull request
Nov 19, 2021
PR #4615 by @meetmangukiya Fixes #4663 Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Allows to register Options method handlers for resources. Currently it gives an
AttributeError: 'RouteTableDef' object has no attribute 'options'Are there changes in behavior for the user?
Related issue number
Resolves #4663
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.