-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import aiokafka fails with latest kafka-python library #590
Comments
Will look into this for 0.6.0. Thanks! |
Thank you Taras. May I ask when is 0.6.0 planned for release? |
@anantkaushik1989 I want to do it this week, but I am hesitant to promise that as my time schedule is quite horrible. Will keep you posted ) |
Thank you so much Taras for the update. Please let me know if I can assist in any way to help you in this. I can raise a small PR with deprecating this exception, if that is fine :) Btw, awesome module. Really makes life so easy for use cases which are IO intensive 👍 |
@anantkaushik1989 If you could replace all usage of ConnectionError from aiokafka.errors package to KafkaConnectionError that would be a great PR. Import in try:
from kafka.errors import KafkaConnectionError
except ImportError:
from kafka.errors import ConnectionError as KafkaConnectionError It should solve the issue. Also bumping kafka-python dependency would be great, as most would want the latest version anyway. |
Steps to reproduce -
Error results as 'ImportError: kafka.errors has no attribute ConnectionError'
ConnectionError is in aiokafka/errors.py, but not in latest kafka-python code base on github.
https://github.com/aio-libs/aiokafka/blob/master/aiokafka/errors.py#L71
https://github.com/dpkp/kafka-python/blob/2.0.1/kafka/errors.py - The commit shows clearly ConnectionError is deprecated.
The text was updated successfully, but these errors were encountered: