Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed racing in coordinator, when assignment is performed before metadata update #120

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

tvoinarovskyi
Copy link
Member

@tvoinarovskyi tvoinarovskyi commented Feb 20, 2017

Fixes #118

@tvoinarovskyi tvoinarovskyi force-pushed the coordinator_metadata_update_fix branch from 1d1efcb to 496996f Compare February 20, 2017 21:52
@codecov-io
Copy link

codecov-io commented Feb 20, 2017

Codecov Report

Merging #120 into master will increase coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
+ Coverage   95.61%   96.61%   +1%     
=======================================
  Files          10       10           
  Lines        1800     1801    +1     
=======================================
+ Hits         1721     1740   +19     
+ Misses         79       61   -18
Impacted Files Coverage Δ
aiokafka/client.py 98.3% <100%> (+0.84%)
aiokafka/group_coordinator.py 94.27% <100%> (+0.01%)
aiokafka/fetcher.py 93.96% <ø> (+0.52%)
aiokafka/consumer.py 98.52% <ø> (+6.89%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de6d52...893f62e. Read the comment docs.

@tvoinarovskyi tvoinarovskyi force-pushed the coordinator_metadata_update_fix branch from 7826a8d to 893f62e Compare February 23, 2017 08:38
@tvoinarovskyi tvoinarovskyi merged commit 6533108 into master Feb 23, 2017
@tvoinarovskyi tvoinarovskyi deleted the coordinator_metadata_update_fix branch February 23, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants