Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow on_partition_assigned and on_partition_revoked to be async functions #190

Merged
merged 2 commits into from
Jul 24, 2017

Conversation

ask
Copy link
Contributor

@ask ask commented Jul 24, 2017

This is a backward compatible change, since it makes async optional.

We require these to be async functions since we need to call async code from within
the on_partitions_assigned and on_partitions_revoked handlers.

Note: Fixes #159

@codecov
Copy link

codecov bot commented Jul 24, 2017

Codecov Report

Merging #190 into master will decrease coverage by 0.1%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   97.22%   97.12%   -0.11%     
==========================================
  Files          11       11              
  Lines        1872     1876       +4     
==========================================
+ Hits         1820     1822       +2     
- Misses         52       54       +2
Impacted Files Coverage Δ
aiokafka/group_coordinator.py 93.84% <75%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426b15c...b4d31fd. Read the comment docs.

@tvoinarovskyi
Copy link
Member

Cool, looks good!

@tvoinarovskyi tvoinarovskyi merged commit 9f37893 into aio-libs:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants