Add flush method to AIOKafkaProducer #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 97.22% 97.17% -0.05%
==========================================
Files 12 12
Lines 2088 2092 +4
==========================================
+ Hits 2030 2033 +3
- Misses 58 59 +1
Continue to review full report at Codecov.
|
tvoinarovskyi
requested changes
Aug 27, 2017
aiokafka/message_accumulator.py
Outdated
| # NOTE: we copy to avoid mutation during `yield from` below | ||
| self._closed = True |
There was a problem hiding this comment.
Why do you set self._closed flag here? It's not needed I think.
There was a problem hiding this comment.
The idea was to avoid buffering more messages while flushing but you are right, that might not be needed. Will remove.
| @@ -201,12 +201,16 @@ def start(self): | |||
| log.debug("Kafka producer started") | |||
|
|
|||
| @asyncio.coroutine | |||
| def flush(self): | |||
| """Wait untill all batches are Delivered and futures resolved""" | |||
|
Hey there, I would love to merge it, but the build it breaks the behavior of ProducerClosed error if |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out the logic to await flushing the message accumulator into a
flush()method that can be used to flush remaining buffered messages without having toclose()the producer.