Timeout on broker metadata sending failure #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
576.bugfix Added handling `asyncio.TimeoutError` on metadata request to broker and metadata update.
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 98.18% 98.38% +0.19%
==========================================
Files 31 31
Lines 5017 5017
==========================================
+ Hits 4926 4936 +10
+ Misses 91 81 -10
Continue to review full report at Codecov.
|
|
Hi! Is anyone interested in merging it? :) |
|
Looks great, thanks! |
| @@ -292,7 +292,7 @@ def get_random_node(self): | |||
|
|
|||
| try: | |||
| metadata = await conn.send(metadata_request) | |||
| except KafkaError as err: | |||
| except (KafkaError, asyncio.TimeoutError) as err: | |||
There was a problem hiding this comment.
I kind of wander why I did not use client.send here. That would handle the issue correctly... Probably we should also close the connection here as we do in send, but that is another enhancement ))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add support for
asyncio.TimeoutErroron requesting metadata during bootstrap and metadata update.Are there changes in behavior for the user?
No changes
Related issue number
Issue #576
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.