-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small cleanups to making children paths #1304
Conversation
This function was a bit hard to unpack so I have added some comments about what is going on. Since we reconstruct nearly everything, create a new tuple instead of replacing
CodSpeed Performance ReportMerging #1304 will improve performances by 50.85%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 95.90% 99.37% +3.47%
==========================================
Files 27 19 -8
Lines 5323 4345 -978
Branches 320 270 -50
==========================================
- Hits 5105 4318 -787
+ Misses 192 22 -170
+ Partials 26 5 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Didn't expect it to speed up that much. Should do join as well |
I couldn't believe |
|
What do these changes do?
This function was a bit hard to unpack so I have added some comments about what is going on.
Since we reconstruct nearly everything, create a new tuple instead of replacing