Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ASCII host case normalization happens before validation #1442

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 30, 2024

What do these changes do?

Fixes a regression was introduced in #954 that prevented uppercase host names from working

#386 covered some of the paths, but we didn't have coverage for the build path

Are there changes in behavior for the user?

Allows uppercase hosts again

Related issue number

fixes #1441

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 30, 2024
@bdraco bdraco mentioned this pull request Nov 30, 2024
5 tasks
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (65d3aed) to head (b33426d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_url_build.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   96.11%   96.08%   -0.04%     
==========================================
  Files          31       31              
  Lines        5876     5882       +6     
  Branches      349      349              
==========================================
+ Hits         5648     5652       +4     
- Misses        202      204       +2     
  Partials       26       26              
Flag Coverage Δ
CI-GHA 96.08% <71.42%> (-0.04%) ⬇️
MyPy 49.39% <28.57%> (-0.04%) ⬇️
OS-Linux 99.55% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.62% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.30% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.24% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.47% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.53% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.55% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.30% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.55% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.62% <100.00%> (+<0.01%) ⬆️
pytest 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #1442 will not alter performance

Comparing fix_host_validation_upper (b33426d) with master (65d3aed)

Summary

✅ 85 untouched benchmarks

@bdraco bdraco changed the title Ensure ascii host case normalization happens before validation Ensure ASCII host case normalization happens before validation Dec 1, 2024
@bdraco bdraco merged commit 20661d6 into master Dec 1, 2024
46 of 48 checks passed
@bdraco bdraco deleted the fix_host_validation_upper branch December 1, 2024 18:33
Mustafsjamal

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support uppercase characters in host
2 participants