fix conflict with norecompute #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by lmignon
Signed-off-by sbidoul
Signed-off-by lmignon
Signed-off-by lmignon
Signed-off-by lmignon
This addon depends on shopinvader_address
Signed-off-by lmignon
Signed-off-by sebastienbeau
Signed-off-by lmignon
In a compute method, we must assign a value to the computed field only if it's different from the original one. Otherwise, the write method will be called every time.
… /current/update routes
This is done to avoid problems when adding new routes, such as /payable,
that would conflict with /{uuid}.
Keep a more natural behavior. Preserve the old routes, but set them as deprecated
Use sudo when running the wizard to avoid having to provide any sort of ACL and RR to related records.
…not mark binding to be updated
Signed-off-by lmignon
Signed-off-by lmignon
Signed-off-by lmignon
Steps to reproduce: - Perform an update without any existing cart Exception: ``` TypeError: SaleOrder._create_empty_cart() missing 1 required positional argument: 'partner_id' ```
This context manager has been deprecated since many versions now, and it's not doing absolutely anything. It was originally used to prevent computed fields to be recomputed when their dependencies are updated, but that's not the case anymore since the apparition of `flush`, where the recomputation is delayed. See: https://github.com/odoo/odoo/blob/be4c1502/odoo/api.py#L823-L826 Also: odoo/odoo@9920f20e
Signed-off-by lmignon
Signed-off-by simahawk
kevinkhao
force-pushed
the
16.0-add-option-rebased
branch
from
592538d to
993d33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see shopinvader#1500