V2.0.0 (Closes #7, #61, #67, #73, #77 #102, #103, #106, #120) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js. This may also help reduce confusion when someone looks at the source code
…tion. Check to see if the parameter is a number, if it is configure reload to create and connect to a websocket running on that port, otherwise do the default (use the servers port, from the server being passed).
Add Timestamp
separate configuration of app routing from starting web socket server
…socketConfig # Conflicts: # lib/reload.js
Added the ability to specifying a custom port to run the WebSocket on (Closes #61)
Replace v0.1 and v0.12 with v6 and v7 (stable and dev) (Closes #73)
* Updated README with API changes * Updated sample app
Removed all old API arguments and replaced with an object of parameters. (Closes #77)
…the app to become simpler for many reasons: * Allows for easy setup in an app * Removes complex two part function for people who have split up app and server (this reverses #71) This commit closes #95 as it allows the reload path to be configured, allowing someone to use the `reload` route in their application if they needed outside of reload. This commit refactors the params again to start with the only required argument app, everything else has defaults and is in an optional object param.
…Invalid arguments are checked for to the best of our ability
Remove server and replace with only port
…addTableOfContentsToReadme
Add table of contents to README (closes #103)
* Updates dependencies in reload and the sample app to the latest. * Removed death as it was never being used. * Added supertest script to call server to express sample app to make things [eaiser](#89 (comment)) to understand. * Cleaned up some parts of the `package.json` in the sample app
Kept and abstracted support for server on command line side only
|
I still need to:
|
Add node 8 support (Closes #106)
alallier
changed the title
…ution. Reload only returns one item in the object, a function called reload that reloads all connected clients
Audited and refactored return API (Closes #120)
alallier
changed the title
Also, refactored time into a proper initialized variable
|
Thank you to everyone who played a part in helping us achieve Version 2.0. If you come across any new bugs or problem please file an issue. |
This was referenced Jul 9, 2017
|
I caught up with most all the changes that were worth having, in my fork. Also updated our differences in my README.md file: Farewell. Feel free to pick mine apart. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload v2.0.0
Added
Modified
reload.jssource file. This is to abstract the reload command line calling with a third argument that is now private and not apart of the public API (PR Kept and abstracted support for server on command line side only #117)package-lock.jsonfiles #109)Removed
API Breaking Changes
This PR makes breaking changes to the reload API. Please reference the new API in the README. The only required argument to reload now is
app. This makes reload a lot easier to use. Reload takes a maximum of two argumentsappand anopts(options) object with the following optional parameters,port,route, andverbose. Two new options were addedportandroute. Reload runs on default port9856unless otherwise specified in theoptsobject.General Notes