Fixing node.js mode not evaluating wait flag properly #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixingBrowserDevelopmentWaitFlagAndDocumentation Conflicts: lib/reload-server.js
|
Resolved merge conflict |
jprichardson
added a commit
that referenced
this pull request
Oct 21, 2015
…AndDocumentation Fixing node.js mode not evaluating wait flag properly
|
Thanks for your help @alallier! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Node.js option wait flag. Before this PR the wait flag was working properly for the browser development option as it was being checked against a string but not for the Node.js option. I changed the code so that no matter what option you choose to use it checks wait against a bool. I also made some changes to the documentation.