update/add interfaces (updatePlugin, modularAccount), update hooks requirements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
force-pushed
the
fangting/MSCA
branch
from
447ffe8 to
02f9977
Compare
Comment on lines
112
to
120
| > event Executed( | ||
| > bytes4 _executePlugin, | ||
| > bytes4 _uoValidator, | ||
| > bytes4 _rtValidator, | ||
| > bytes4 _preHook, | ||
| > bytes4 _postHook, | ||
| > bytes4[] _globalPreHooks, | ||
| > bytes4[] _globalPostHooks | ||
| > ); |
There was a problem hiding this comment.
This should not be part of the standard in this form. Listing all associated functions (non-execution) is not necessary, because plugin state is derivable from other events. Also, bytes4 does not uniquely identify a function according to the spec - it might be enough depending on the spec implementation's internal storage representation, but not in a general sense.
fangting-alchemy
force-pushed
the
fangting/MSCA
branch
from
02f9977 to
3541ac4
Compare
adam-alchemy
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update/add interfaces (updatePlugin, modularAccount), update hooks requirements