Fix solidity lexer's handling of inline assembly #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax highlighting in solidity breaks to due the assembly rule improperly pushing the state (it pushes once for the keyword, then again for the '{')
fixes assembly to not error out when '.' is used
alecthomas
reviewed
Jan 14, 2025
|
Sorry, I've now edited the test to include inline assembly. |
|
Test is failing slightly. |
Addes a newline to the end
|
That's really strange, cause the test worked locally. It seems there is an added newline at the end despite there not being one in the file? In any case, I went ahead and added it, it should work now hopefully. Sorry for the inconvenience! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax highlighting in solidity breaks to due the assembly rule improperly pushing the state (it pushes once for the keyword, then again for the '{') This fix merges the opening '{' into the assembly keyword pattern.
Link to chroma playground
