-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean dev environment #3205
Clean dev environment #3205
Conversation
dceffd0
to
757b7d0
Compare
- "127.0.0.1:15432:5432" | ||
- "127.0.0.1:5432:5432" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m on macOS, but I’ve seen some people using certain Linux distros run into problems when using default ports, because they’d also have for example a postgres server running on their host machine already by default. This might be the reason why this is set up to use the default ports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a lot of linux distro's have installed postgres by default. And if people are running postgres without them knowing then making them conscious of that is not a bad thing right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the port change, even if I find it unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of utilizing standard ports as much as possible.
docker-compose.dev.yml
Outdated
@@ -2,10 +2,9 @@ version: "3.2" | |||
|
|||
services: | |||
postgres: | |||
image: postgres:10.0 | |||
hostname: postgres | |||
image: postgres:14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 15, which is the latest? And: which version are you running with your Aleph deployment, if I may ask?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto. 15 has been around for about 9 months, so should be fairly stable.
- "127.0.0.1:15432:5432" | ||
- "127.0.0.1:5432:5432" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the port change, even if I find it unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two items pending from my point of view:
- use postgres 15
- update the docs with the ES UI tooling
Let me know if you want me to do those or if you need any help @monneyboi
I added some documentation about how to approach elasticsearch and updated postgres to major version 15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some very minor suggestion to the documentation updates. Looks good otherwise!
1a878b3
to
89e58a5
Compare
It occurred to me that there were some references left in the docs regarding ports, fixed those. While doing that i noticed that there were multiple entries for connecting to database / elasticsearch. I merged the entries from the "technical FAQ" into these in the "developer setup" as they contained the same information. Of the two, developer setup seemed to be the right place. |
…emove unused shell commands from makefile
4e1641e
to
e601cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the sensible changes!
I propose to use default ports for services, and to drop dejavu from the development setup as management software/gui would be up for personal preference.
I also removed the
hostname
params as they were the same as the defaults, plus bumped postgres to version 14.