-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure tech docs #3569
Restructure tech docs #3569
Conversation
Release/3.17.0
refer to alephdata/aleph/raw/ to get actual files
"shell aleph upgrade" is mandatory for 1st time installs.
download actual files instead of HTML wrapped configuration
Order of commands made more clean
a991be7
to
fd140ed
Compare
96080cd
to
aa4e73f
Compare
Aleph’s technical documentation has been growing organically over the years. New information has been mostly added to existing pages, resulting in a few very long pages that are difficult to read and digest. This makes it difficult for authors/contributors to add new contents, and it makes it difficult for users to find relevant information. This change reorganizes existing contents to make contents easier to discover, but I’ve also updated some of the frequently accessed contents and added new contents.
These images were previously referenced in the old user guide and technical documentation. I’ve moved all images that are still used into a directory structure following the content structure that hopefully makes it easier to maintain. This commit only deletes the "old" copies.
Vale is an open-source tool that helps enforcing a consistent writing style and prevents common spelling and grammar errors. I set this up as an experiment, not sure I’ll keep it.
aa4e73f
to
9ed8928
Compare
This change runs the workflow whenever a pull request is opened or updated or when a push to the `develop` or `main` branches occurs.
In order to publish documentation changes, they currently need to be merged directly into main (which is only possible if they do not contain non-docs changes). Merging documentation changes into develop means that they will only get publish on the next release. In most cases, documentation changes are enhancements that are not coupled to a release and should be published as soon as possible, and deploying from develop accounts for this use cases.
7890437
to
3fefcf7
Compare
3fefcf7
to
03af928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure seems sensible to me, checked the test site and it's looking great. Giving this the thumbs up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the rework, the structure makes a lot of sense to me. Thanks for all the hard work on this, @tillprochaska !
@@ -28,7 +30,7 @@ jobs: | |||
docs-path: ./docs | |||
|
|||
deploy: | |||
if: ${{ github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch' }} | |||
if: ${{ github.ref == 'refs/heads/develop' || github.event_name == 'workflow_dispatch' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking but the intention here is to leave it like this so we can update docs by merging to develop
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch, this is indeed intended!
In order to publish documentation changes, they currently need to be merged directly into main (which is only possible if they do not contain non-docs changes). Merging documentation changes into develop means that they will only get published on the next release.
I think deploying docs from develop is sensible: In most cases, small changes will get published faster without us having to remember to merge to the (non-default) main branch. Also, this has sometimes caused merge conflicts in the past.
In case we really want to publish a documentation change only after the next stable release, this requires a little more work now, but this case is quite rate.
Aleph’s technical documentation has been growing organically over the years. New information has been mostly added to existing pages, resulting in a few very long pages that are difficult to read and digest. This makes it difficult for authors/contributors to add new contents, and it makes it difficult for users to find relevant information.
This change reorganizes existing contents to make contents easier to discover, but I’ve also updated some of the frequently accessed contents and added new contents.
Preview
You can preview the changes here: https://aleph-docs-preview.netlify.app/developers/
Changes
#3064 has a complete overview of progress/changes, but below is a summary of the most relevant changes:
New
Updated
Removed
Todos
Fixes #3064