This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified a Service Worker I've used before on static sites. It's network-first, cache-fallback so it'll work offline, but still get instant content updates without breaking Netlify's cache invalidation. Given all assets are inlined at this stage, this method works well. The main downside is that shaky network conditions will still affect this site, but as it's only
html
for now, it's not a big deal.There's a new offline page that lists the key pages. I've also added a trailing slash to the footer links. Netlify auto-redirects
/code-of-conduct
to/code-of-conduct/
so that would count as separate URLs in the service worker. Plus skipping the redirect will improve performance.Future ideas for the SW could include: