Feat/typescript d #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
OmgImAlexis
reviewed
Aug 23, 2022
| * A function that will be called with an error that may be thrown | ||
| * This function may return a promise | ||
| */ | ||
| type ErrorHandler = (error: Error) => any |
There was a problem hiding this comment.
The return type of this should be void no?
| * (ie. node and script name are not passed) | ||
| * This function may return a promise | ||
| */ | ||
| type AsyncMain = (...args: string[]) => any |
There was a problem hiding this comment.
The return type of this should be void no?
| * If you don't provide an error handler a default one will be used which merely logs the error | ||
| * using `console.error()` | ||
| */ | ||
| declare function am(main: AsyncMain, errorHandler?: ErrorHandler): Promise<ReturnType<AsyncMain>>; |
There was a problem hiding this comment.
This should just be Promise<void> since AsyncMain's return type doesn't change.
|
@userpixel looks good, just had a few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplified version of #13 which doesn't rewrite the codebase