-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Console App #12
base: main
Are you sure you want to change the base?
New Console App #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvillajos Thanks for your PR! However, I'd like you to take a look at the "proper" way of building a console app.
EndProject | ||
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "YouTubeSubtitlesExtractorConsoleApp", "consoleApp\YouTubeSubtitlesExtractorConsoleApp\YouTubeSubtitlesExtractorConsoleApp.csproj", "{98A6F65D-97EA-4AE2-B662-76497402D5B8}" | ||
EndProject | ||
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "consoleapp", "consoleapp", "{203D49CC-6E1F-49BA-8DE9-AE7CE216FC9E}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The console app should be under the samples
directory, instead of consoleapp
|
||
<PropertyGroup> | ||
<OutputType>Exe</OutputType> | ||
<TargetFramework>net6.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As .NET 8 is around the corner, I'd like to target this app to net8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the generic builder pattern like:
var host = Host.CreateDefaultBuilder(args);
...
Please refer to: https://learn.microsoft.com/dotnet/core/extensions/generic-host
Added new console project to test use case