exec in container #152
Open
exec in container #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
OhYee
force-pushed
the
container-exec
branch
from
8a055c3 to
47fcf38
Compare
halegreen
reviewed
Nov 25, 2021
| Preconditions.checkArgument(!Strings.isNullOrEmpty(region), "Region cannot be blank"); | ||
| Preconditions.checkArgument(region.matches(REGION_PATTERN), "Illegal region"); | ||
| // Preconditions.checkArgument(region.matches(REGION_PATTERN), "Illegal region"); |
| return execWebsocket; | ||
| } | ||
|
|
||
| public void setCallback(ExecCallback callback) { |
There was a problem hiding this comment.
java 里面为啥是InstanceExecResponse 里面 setCallback，而不是 instanceExec 的时候 withCallbakc()
行为和 nodejs, golang 一致？
Ethan92
reviewed
Dec 22, 2021
pom.xml
Outdated
| @@ -5,7 +5,7 @@ | |||
| <groupId>com.aliyun</groupId> | |||
| <artifactId>aliyun-java-sdk-fc</artifactId> | |||
| <packaging>jar</packaging> | |||
| <version>1.8.24</version> | |||
| <version>1.8.26</version> | |||
There was a problem hiding this comment.
版本改成1.8.31，现在master已经是1.8.30了
| @@ -49,8 +53,7 @@ | |||
| private final DefaultFcClient client; | |||
| private final Config config; | |||
|
|
|||
| public FunctionComputeClient(String region, String uid, String accessKeyId, | |||
| String accessKeySecret) { | |||
| public FunctionComputeClient(String region, String uid, String accessKeyId, String accessKeySecret) { | |||
There was a problem hiding this comment.
这些diff应该是IDE格式化代码引入的，保持原有的代码格式不要改动吧
OhYee
force-pushed
the
container-exec
branch
from
9ebe0a9 to
6e3863d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.