This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
widthConstraint no longer has any effect #3517
Comments
|
Confirmed. The constraint values were overwritten in the new multifont option handling. |
wimrijnders
added a commit
to wimrijnders/vis
that referenced
this issue
Oct 4, 2017
Fixes almende#3517. Due to changed logic in the label font handling, the option values for `widthConstraint` and `heightConstraint` were overwritten. The fix is in effect a reversal of two code lines: parsing constraint options should come *after* parsing (multi)font options. Further changes: - Additional 1-liner fix: constraint values were not copied for edge-instance specific options. - Small refactoriing of `Label#constrain()` in order to separate concerns - Added unit test for regression testing of this issue. This leads to the curious observation that, while the actual change is two lines of source code, this resulted in a +-150 line regression test.
yotamberk
pushed a commit
that referenced
this issue
Oct 8, 2017
* Network: Retain constraint values in label font handling Fixes #3517. Due to changed logic in the label font handling, the option values for `widthConstraint` and `heightConstraint` were overwritten. The fix is in effect a reversal of two code lines: parsing constraint options should come *after* parsing (multi)font options. Further changes: - Additional 1-liner fix: constraint values were not copied for edge-instance specific options. - Small refactoriing of `Label#constrain()` in order to separate concerns - Added unit test for regression testing of this issue. This leads to the curious observation that, while the actual change is two lines of source code, this resulted in a +-150 line regression test. * Made unit test more linear, removed tabs * Made 'enhanced subset' of unit test * Removed TODO from comment * Culled redundant nodes from unit test
primozs
pushed a commit
to primozs/vis
that referenced
this issue
Jan 3, 2019
* Network: Retain constraint values in label font handling Fixes almende#3517. Due to changed logic in the label font handling, the option values for `widthConstraint` and `heightConstraint` were overwritten. The fix is in effect a reversal of two code lines: parsing constraint options should come *after* parsing (multi)font options. Further changes: - Additional 1-liner fix: constraint values were not copied for edge-instance specific options. - Small refactoriing of `Label#constrain()` in order to separate concerns - Added unit test for regression testing of this issue. This leads to the curious observation that, while the actual change is two lines of source code, this resulted in a +-150 line regression test. * Made unit test more linear, removed tabs * Made 'enhanced subset' of unit test * Removed TODO from comment * Culled redundant nodes from unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After PR #3486 widthConstraint no longer seems to have any effect.
I noticed this in our networks after rebasing and confirmed by navigating to: vis/test/network/maximumWidthEdgeCase.html
Before:
After:
The text was updated successfully, but these errors were encountered: