-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding 3rd level hierarchy for nested groups fixing #2846 #3940
base: develop
Are you sure you want to change the base?
Conversation
Fixes linting Fixing lint & test...
any news on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jogai ,
I appreciate the PR, but I cannot accept it like this. You've changed the nestedInGroup
property and introduced a breaking change without changing the docs.
You've also applied a lot of spacing changes which make it very difficult to understand the actual changes you've added.
Please add this change to the docs and remove all the spacing so I can add this.
I've also now branched out to a new fork of my own including only Timeline.
If you can reapply the change here: https://github.com/yotamberk/timeline-plus
you will find this fix there within a week or two.
Awesome fix! Thanks for your contribution! Future PRs will be reviewed and added in the new fork
Thank you for looking into this. I'll see what I can do |
Hi, |
This has been applied properly in timeline-plus v2.1.8 |
fixes #2846
Taken changes from @JobrianTrinidad