Turn the WCAG 2.2 design elements into macros #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
romaricpascal
approved these changes
Aug 20, 2024
owenatgov
force-pushed
the
wcag-callout-macro
branch
from
4e2145f to
a78c41c
Compare
owenatgov
force-pushed
the
wcag-callout-macro
branch
from
a78c41c to
2b6f62b
Compare
owenatgov
force-pushed
the
wcag-callout-macro
branch
from
2b6f62b to
9842464
Compare
|
@querkmachine @romaricpascal I've addressed both your comments. Whilst you've both already approved, to be belt and bracers could I get one of you to sus this out one more time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Turns the WCAG 2.2 callouts and criteria notes linked to by the callouts into respective macros and replaces all instances of the callouts and notes in guidance with the macros.
Additionally, this PR fixes few missed duplicate content issues found in content, adjusts the classes used for the WCAG designs to be more specific to their function and moves the override of
strongelement styling when they're govuk tags into prose scope since we always want our tags to be regular font size.Why
The WCAG 2.2 designs are repeated across 34 pages of content and we're effectively rebuilding them every time we use them. Turning them into macros makes the website lighter and our content less complex.
We've gone back and forth around if we want to do this since the designs are going to be removed eventually, however even if it's a few months, it's still worth doing for neatness and it makes these designs easier to repurpose in the future.
Notes
I'm not super happy with how I've managed inconsistencies between the callout content. The
introTypeattribute feels a bit hacky but managable, however the override attributes which I'm only using for the images page feel messy. I'm not sure if there's a better alternative though and welcome suggestions from others on this.