Make use of default category var

[joelanman]

Earlier in the code a default category is set if one is not sent:

 {%- set category -%}
    {%- if params.category -%}
      {{ params.category }}
    {%- else -%}
      analytics
    {%- endif -%}
  {%- endset -%}

However later on the code refers to params.category - which could be null. If it is null the javascript breaks. This PR refers to category instead to make sure a value is present.

[netlify]

✅ You can preview this change here:

Name	Link
🔨 Latest commit	d25029d
🔍 Latest deploy log	https://app.netlify.com/sites/govuk-design-system-preview/deploys/67b8538bf531740008e614a5
😎 Deploy Preview	https://deploy-preview-4136--govuk-design-system-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[owenatgov]

Makes perfect sense to me.

For some reason netlify failed to deploy this and is still recording the deploy preview a failure even though I re-ran it and it deployed fine. Something for a second reviewer to keep in mind.

[joelanman]

also I think the default code could be rewritten as either of these:

{% set category = params.category or "analytics" %}

{% set category = params.category | default "analytics" %}

[romaricpascal]

@owenatgov I've approved @joelanman changes, but also taken the opportunity to rewrite how the category is assigned as he suggested as it makes things easier to parse given we're only assigning text to the variable. Also took care of the title right after for consistency.

Would you mind either giving a second green tick or just merging if you think it's OK, please? 😊

[owenatgov]

Looks fine to me, just gonna merge 😎