Add new finder for authorised fuels (Defra) #3111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngocd
reviewed
Feb 3, 2025
| type: "string", | ||
| pattern: "^[1-9][0-9]{3}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[0-1])$", | ||
| }, | ||
| authorised_fuel_address: { |
There was a problem hiding this comment.
is this missing a "county" field?
There was a problem hiding this comment.
I had a look at this, I think we need values to add in. Not sure if we can use a standard list, as the countries are selectable themselves.
|
Heya, I'm not sure if this is waiting for a response from publishing platform but since it came up on our seal bot today I figured I'd stick my oar in!
|
Apologies, got put on hold while we're waiting on the user to confirm they still wanted this finder. We've coincidentally gotten confirmation from user today, we'll be wrapping this up next week. |
lauraghiorghisor-tw
force-pushed
the
add-authorised-fuels-finder
branch
from
c303ed3 to
e9c5fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello