Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New schema for Defra Approved Appliances Specialist Finder #3118

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minhngocd
Copy link
Contributor

https://trello.com/c/tCDDVGcv/3383-new-specialist-finder-for-defra-appliances

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

@mike3985
Copy link
Contributor

I'm not all that familiar with content schemas, but saw the name of this pull request and wanted to check that there's nothing needing to be updated in Content Data API to support the change? (re: https://docs.publishing.service.gov.uk/repos/publishing-api/content_schemas/adding-a-new-schema.html#ensure-new-content-schema-text-can-be-parsed-by-content-data-api)

@JonathanHallam
Copy link
Contributor

Heya, I'm not sure if this is waiting for a response from publishing platform but since it came up on our seal bot today I figured I'd stick my oar in!

  • Would you like us to review this?
  • Would you mind adding a bit of blurb in the PR description to go with the trello link please :)

@yndajas
Copy link
Member

yndajas commented Feb 26, 2025

@minhngocd I'm going to mark this one as a draft for now so that we stop being alerted about it in our team channel. Do let us know if you need anything from us on it

@yndajas yndajas marked this pull request as draft February 26, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants