Consolidate model spec in general test file

Our validations are now largely defined by the schemas and are being applied to the models without the need to be manually defined and configured. This validation in tested by our feature tests. It seems unnecessary to test this validation twice.
alphagov · Feb 27, 2025 · a4d70bd · a4d70bd
1 parent 9802a43
commit a4d70bd
Show file tree

Hide file tree

Showing 27 changed files with 28 additions and 472 deletions.
diff --git a/spec/models/aaib_report_spec.rb b/spec/models/aaib_report_spec.rb
diff --git a/spec/models/algorithmic_transparency_record_spec.rb b/spec/models/algorithmic_transparency_record_spec.rb
diff --git a/spec/models/asylum_support_decision_spec.rb b/spec/models/asylum_support_decision_spec.rb
diff --git a/spec/models/business_finance_support_scheme_spec.rb b/spec/models/business_finance_support_scheme_spec.rb
diff --git a/spec/models/cma_case_spec.rb b/spec/models/cma_case_spec.rb
diff --git a/spec/models/countryside_stewardship_grant_spec.rb b/spec/models/countryside_stewardship_grant_spec.rb
diff --git a/spec/models/data_ethics_guidance_document_spec.rb b/spec/models/data_ethics_guidance_document_spec.rb
diff --git a/spec/models/document_type_spec.rb b/spec/models/document_type_spec.rb
@@ -0,0 +1,28 @@
+require "spec_helper"
+require "models/valid_against_schema"
+
+EXCEPTIONS_TO_GENERAL_TESTING = %w[
+  ai_assurance_portfolio_technique
+  animal_disease_case
+  drcf_digital_markets_research
+  export_health_certificate
+  traffic_commissioner_regulatory_decision
+].freeze
+
+Dir["lib/documents/schemas/*.json"].each do |file|
+  schema = JSON.parse(File.read(file))
+  format = schema["filter"]["format"]
+
+  next if EXCEPTIONS_TO_GENERAL_TESTING.include?(format)
+
+  RSpec.describe format.classify.constantize do
+    let(:payload) { FactoryBot.create(format.to_sym) }
+    include_examples "it saves payloads that are valid against the 'specialist_document' schema"
+
+    it "is not exportable" do
+      unless subject.instance_of?(BusinessFinanceSupportScheme)
+        expect(subject.class).not_to be_exportable
+      end
+    end
+  end
+end
diff --git a/spec/models/employment_appeal_tribunal_decision_spec.rb b/spec/models/employment_appeal_tribunal_decision_spec.rb
diff --git a/spec/models/employment_tribunal_decision_spec.rb b/spec/models/employment_tribunal_decision_spec.rb
diff --git a/spec/models/esi_fund_spec.rb b/spec/models/esi_fund_spec.rb
diff --git a/spec/models/farming_grant_spec.rb b/spec/models/farming_grant_spec.rb
diff --git a/spec/models/flood_and_coastal_erosion_risk_management_research_report_spec.rb b/spec/models/flood_and_coastal_erosion_risk_management_research_report_spec.rb
diff --git a/spec/models/international_development_fund_spec.rb b/spec/models/international_development_fund_spec.rb
diff --git a/spec/models/life_saving_maritime_appliance_service_station_spec.rb b/spec/models/life_saving_maritime_appliance_service_station_spec.rb
diff --git a/spec/models/maib_report_spec.rb b/spec/models/maib_report_spec.rb
diff --git a/spec/models/marine_notice_spec.rb b/spec/models/marine_notice_spec.rb
diff --git a/spec/models/medical_safety_alert_spec.rb b/spec/models/medical_safety_alert_spec.rb
diff --git a/spec/models/product_safety_alert_report_recall_spec.rb b/spec/models/product_safety_alert_report_recall_spec.rb
diff --git a/spec/models/protected_food_drink_name_spec.rb b/spec/models/protected_food_drink_name_spec.rb
diff --git a/spec/models/raib_report_spec.rb b/spec/models/raib_report_spec.rb