Extract canon from registry #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way `Canon` (and other implementations of `CustomEntitySerializer`) can be used outside of Registry, which is useful for mapping world entities to data outside of legion. A shared `Canon` should mostly need read acces, so `RwLock` is a better choice. I don't think requiring `Sync` for `S` is too burdensome either.
alyjak
force-pushed
the
extract_canon_from_registry
branch
from
55d2c2a to
ab3527f
Compare
TomGillen
added
type: breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Registryto useArc<RwLock<S: CustomEntitySerializer>This way
Canon(and other implementations ofCustomEntitySerializer) can be used outside of Registry, which is useful for mapping world entities to data outside of legion. RwLock is more friedly for this use case, and requiringSend + SynconSinstead of justSenddoesn't seem too burdensome.